Update StarNotary.sol - It needs a a constructor to compile now!#9
Open
noahfigueras wants to merge 2 commits intoudacity:masterfrom
Open
Update StarNotary.sol - It needs a a constructor to compile now!#9noahfigueras wants to merge 2 commits intoudacity:masterfrom
noahfigueras wants to merge 2 commits intoudacity:masterfrom
Conversation
Author
|
Also, just found out _transferFrom function doesn't exist. The one currently available is _transfer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to compile the sample code for my course and It throws me the following compiler error:
node_modules/openzeppelin-solidity/contracts/token/ERC721/ERC721.sol:93:5: Missing implementation:
constructor (string memory name, string memory symbol) public {
^ (Relevant source part starts here and spans across multiple lines).
It looks like it needs the ERC721 token to Initialize with name and symbol as parameters in the constructor if I'm not wrong. I implemented that and now it compiles with no errors.